[webkit-reviews] review granted: [Bug 56734] AX: showContextMenu not working in WK2 : [Attachment 86369] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 56734: AX: showContextMenu not working in WK2
https://bugs.webkit.org/show_bug.cgi?id=56734

Attachment 86369: patch
https://bugs.webkit.org/attachment.cgi?id=86369&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86369&action=review

> Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:886
> +    WebCore::Page* page = [m_webView page];

Why does this need the WebCore:: prefix and nothing else in this function does?


> Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:891
> +    if (!controller)
> +	   return;

I don’t think this can ever be 0, so this check is not needed.