[webkit-reviews] review denied: [Bug 56770] Speed up HitTestResult : [Attachment 86365] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 21 14:36:15 PDT 2011
Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Geoff Pike
<gpike at chromium.org>'s request for review:
Bug 56770: Speed up HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=56770
Attachment 86365: Patch
https://bugs.webkit.org/attachment.cgi?id=86365&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86365&action=review
Looks reasonable, aside from a style nitpick.
> Source/WebCore/rendering/HitTestResult.cpp:583
> + for (NodeSet::const_iterator it =
other.m_rectBasedTestResult->begin(),
> + last = other.m_rectBasedTestResult->end();
The indent is weird here. Come to the dark side... Put it on one line :)
More information about the webkit-reviews
mailing list