[webkit-reviews] review granted: [Bug 56764] QT plug-in loads controller at top of movie not bottom : [Attachment 86355] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 21 13:02:22 PDT 2011


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 56764: QT plug-in loads controller at top of movie not bottom
https://bugs.webkit.org/show_bug.cgi?id=56764

Attachment 86355: Patch
https://bugs.webkit.org/attachment.cgi?id=86355&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86355&action=review

Otherwise, r=me.

> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:234
> +	       RetainPtr<CALayer> realPluginLayer(AdoptNS,
reinterpret_cast<CALayer *>(value));

This adoption seems wrong.


More information about the webkit-reviews mailing list