[webkit-reviews] review granted: [Bug 56665] REGRESSION (r79953): Can't type in MS Outlook 2011 : [Attachment 86343] fix patch 2: addressed the reviews

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Chang Shu <cshu at webkit.org>'s
request for review:
Bug 56665: REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

Attachment 86343: fix patch 2: addressed the reviews
https://bugs.webkit.org/attachment.cgi?id=86343&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86343&action=review

> Source/WebKit/mac/WebView/WebView.mm:5008
> +    if ([self isEditable] != flag && _private->page) {

This looks rather suspicious.  -[WebView setEditable:] should always work, so
failing when there is no page would be a bug. Is that even a possible
situation?

> LayoutTests/ChangeLog:11
> +	   Restore the expected result before r79953. r79953 changed behavior
slightly in function
> +	   finishedLoadingWithDataSource in file
mac/WebView/WebHTMLRepresentation.mm, where
> +	   core(webFrame)->editor()->applyEditingStyleToBodyElement() was
called but not before r79953
> +	   or after this patch.

I'm wondering if that code is correct. Not something to fix in this bug,
obviously.