[webkit-reviews] review requested: [Bug 56704] [fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry* : [Attachment 86337] Fixed stylistic problems

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 21 11:13:35 PDT 2011


Eric U. <ericu at chromium.org> has asked	for review:
Bug 56704: [fileapi/chromium] Fetch platform path using GetMetadata before
creating File from FileEntry*
https://bugs.webkit.org/show_bug.cgi?id=56704

Attachment 86337: Fixed stylistic problems
https://bugs.webkit.org/attachment.cgi?id=86337&action=review

------- Additional Comments from Eric U. <ericu at chromium.org>
I think I've gotten all the fixes in.  Sorry about all the style kruft--I'm
doing this on my Windows box, where I'm not set up to run check-webkit-style,
and I've been doing too much Chromium code lately.

The reason we need GetPathResult is that GetPathHelper will be deleted [by the
caller] as soon as the callback is called--it's just the way that interface
works.


More information about the webkit-reviews mailing list