[webkit-reviews] review granted: [Bug 46796] Extend constant pool to be able to store 16 bits instructions with a constant : [Attachment 85449] Extend constant pool to be able to store 16 bit instructions with a constant

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has granted Gabor Loki <loki at webkit.org>'s
request for review:
Bug 46796: Extend constant pool to be able to store 16 bits instructions with a
constant
https://bugs.webkit.org/show_bug.cgi?id=46796

Attachment 85449: Extend constant pool to be able to store 16 bit instructions
with a constant
https://bugs.webkit.org/attachment.cgi?id=85449&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85449&action=review

LGTM, r=me with a small style fix.

> Source/JavaScriptCore/assembler/AssemblerBufferWithConstantPool.h:251
> +	   if (isReusable)
> +	       for (int i = 0; i < m_numConsts; ++i) {
> +		   if (m_mask[i] == ReusableConst && m_pool[i] == constant) {
> +		      
putIntegral(static_cast<IntegralType>(AssemblerType::patchConstantPoolLoad(insn
, i)));
> +		       correctDeltas(sizeof(IntegralType));
> +		       return;
> +		   }
> +	       }

Please add { ... }