[webkit-reviews] review denied: [Bug 38095] webkit should implement -moz-any selector (as -webkit-any obviously) : [Attachment 86131] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 38095: webkit should implement -moz-any selector (as -webkit-any obviously)
https://bugs.webkit.org/show_bug.cgi?id=38095

Attachment 86131: Patch
https://bugs.webkit.org/attachment.cgi?id=86131&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Looks generally good. 

You  will need to modify RuleSet::collectFeatures() and pals (in
CSSStyleSelector.cpp) to scan the content of the :any selector lists too.
Otherwise you get bugs at least with style sharing. r- for that.

As you note, you should (probably in a separate patch) eliminate
CSSSelector::m_simpleSelector in favor of using m_selectorList.

Matching of these won't be very well optimized as neither the ancestor
identifier filter or fastCheckSelector can be used with them. If they get
popular we need to think of ways to optimize them.

(personally I don't think typedeffing  stuff like
Vector<OwnPtr<CSSParserSelector> > is always helpful. It tends to make code
more opaque)