[webkit-reviews] review granted: [Bug 56651] Web Inspector: migrate Inspector.json to valid JSON types. : [Attachment 86267] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 56651: Web Inspector: migrate Inspector.json to valid JSON types.
https://bugs.webkit.org/show_bug.cgi?id=56651

Attachment 86267: Patch
https://bugs.webkit.org/attachment.cgi?id=86267&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86267&action=review

Please address comments before landing.

> Source/WebCore/inspector/InspectorConsoleAgent.cpp:237
> +    int messageCount = m_consoleMessages.size();

If you are changing type of the counter, it should become size_t, not int.

>> Source/WebCore/inspector/InspectorConsoleAgent.h:97
>> +	HashMap<String, int> m_counts;
> 
> ditto

I agree, I'd rather leave unsigned as value type here and cast if needed when
formatting protocol messages.