[webkit-reviews] review granted: [Bug 56708] Web Inspector: make frameId in network agent of type string, not unsigned long. : [Attachment 86259] [PATCH] With right errors removed from header.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 56708: Web Inspector: make frameId in network agent of type string, not
unsigned long.
https://bugs.webkit.org/show_bug.cgi?id=56708

Attachment 86259: [PATCH] With right errors removed from header.
https://bugs.webkit.org/attachment.cgi?id=86259&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86259&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:236
> +    unsigned long long address = reinterpret_cast<uintptr_t>(pointer);

does unsigned long long always fit pointer type?

> Source/WebCore/inspector/InspectorResourceAgent.cpp:238
> +    return String::format("%.0llX", address);

We should use a map address->id to enumerate all iframes instead of exposing
raw address over the protocol.