[webkit-reviews] review granted: [Bug 56714] Rename ThreadSafeShared to ThreadSafeRefCounted : [Attachment 86276] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 19 18:02:50 PDT 2011


Adam Barth <abarth at webkit.org> has granted Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 56714: Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

Attachment 86276: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=86276&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86276&action=review

Sounds like a good idea to me.	I see that it's on our list of renames we'd
like to do in the future.  Thanks!

> Source/JavaScriptCore/wtf/CrossThreadRefCounted.h:41
>      // Used to allowing sharing data across classes and threads (like
ThreadedSafeShared).

Missed this one?

> Source/JavaScriptGlue/gyp/JavaScriptGlue.gypi:1
> -{
> +ThreadSafeRefCounted{

Typo?


More information about the webkit-reviews mailing list