[webkit-reviews] review granted: [Bug 56715] [Qt] Refactor handling of deferred loads : [Attachment 86272] Proposed patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 19 15:08:32 PDT 2011
Benjamin Poulain <benjamin at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 56715: [Qt] Refactor handling of deferred loads
https://bugs.webkit.org/show_bug.cgi?id=56715
Attachment 86272: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=86272&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
That looks good to me.
I you have the courage to continue cleaning, it would be nice to make
redirection a bit easier to understand. :)
Maybe the constructor should be just calling init() so that the same init()
could be called from the redirection called. This recycling of the current
QNetworkReplyHandler is confusing :(
More information about the webkit-reviews
mailing list