[webkit-reviews] review granted: [Bug 56712] [Qt] Remove support for Qt 4.6 : [Attachment 86269] Proposed patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 19 12:03:04 PDT 2011
Benjamin Poulain <benjamin at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 56712: [Qt] Remove support for Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=56712
Attachment 86269: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=86269&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86269&action=review
R+ :)
Just update the code to match the coding style before landing.
> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:553
> if (m_resourceHandle->firstRequest().reportUploadProgress()) {
> - connect(m_reply, SIGNAL(uploadProgress(qint64, qint64)),
> - this, SLOT(uploadProgress(qint64, qint64)), SIGNAL_CONN);
> + connect(m_reply, SIGNAL(uploadProgress(qint64, qint64)), this,
SLOT(uploadProgress(qint64, qint64)));
> }
Coding style, you don't need the brackets.
More information about the webkit-reviews
mailing list