[webkit-reviews] review denied: [Bug 56712] [Qt] Remove support for Qt 4.6 : [Attachment 86268] Proposed patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Andreas Kling
<kling at webkit.org>'s request for review:
Bug 56712: [Qt] Remove support for Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=56712

Attachment 86268: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=86268&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86268&action=review

> Source/WebCore/platform/graphics/qt/FontQt.cpp:180
> +

Empty line? :)

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:44
>  #define SIGNAL_CONN Qt::DirectConnection

Why not replacing all the instance of SIGNAL_CONN by Qt::DirectConnection?

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:382
>	       response.setHTTPHeaderField(QString::fromAscii(pair.first),
QString::fromAscii(pair.second));

for a follow up: QString::fromAscii() should be QString::fromLatin1().