[webkit-reviews] review requested: [Bug 56688] Fix clang static analyzer warning in WebCoreViewFactory.m : [Attachment 86220] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 18 15:09:25 PDT 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 56688: Fix clang static analyzer warning in WebCoreViewFactory.m
https://bugs.webkit.org/show_bug.cgi?id=56688

Attachment 86220: Patch
https://bugs.webkit.org/attachment.cgi?id=86220&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Fixes the following static analyzer warning:

Source/WebCore/page/mac/WebCoreViewFactory.m:45:5: warning: Returning 'self'
while it is not set to the result of '[(super or self) init...]'
return self;
^

* page/mac/WebCoreViewFactory.m:
(-[WebCoreViewFactory init]): Assign the result of [super init]
to self.
---
 2 files changed, 17 insertions(+), 1 deletions(-)


More information about the webkit-reviews mailing list