[webkit-reviews] review granted: [Bug 49649] [GTK] On-demand event-listeners for DOM event signals : [Attachment 86173] eventlistener.diff

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 49649: [GTK] On-demand event-listeners for DOM event signals
https://bugs.webkit.org/show_bug.cgi?id=49649

Attachment 86173: eventlistener.diff
https://bugs.webkit.org/attachment.cgi?id=86173&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86173&action=review

Nice!

> Source/WebCore/bindings/gobject/WebKitDOMEventTarget.cpp:87
> +    WebKitDOMEventTargetIface* iface;
> +
> +    g_return_val_if_fail(WEBKIT_DOM_IS_EVENT_TARGET(target), FALSE);
> +    g_return_val_if_fail(eventName, FALSE);
> +
> +    iface = WEBKIT_DOM_EVENT_TARGET_GET_IFACE(target);

You'd save a few lines by moving the the declaration of iface to where you
first use it.

> Source/WebCore/bindings/gobject/WebKitDOMEventTarget.cpp:102
> +    WebKitDOMEventTargetIface* iface;
> +
> +    g_return_val_if_fail(WEBKIT_DOM_IS_EVENT_TARGET(target), FALSE);
> +    g_return_val_if_fail(eventName, FALSE);
> +
> +    iface = WEBKIT_DOM_EVENT_TARGET_GET_IFACE(target);

Ditto.

> Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:52
> +
> +    gboolean      (* add_event_listener)(WebKitDOMEventTarget* target,
> +					    const char		* eventName,
> +					    GCallback		  handler,
> +					    gboolean		  bubble,
> +					    gpointer		  userData);
> +    gboolean      (* remove_event_listener)(WebKitDOMEventTarget* target,
> +					       const char	   * eventName,

> +					       GCallback	     handler,
> +					       gboolean 	     bubble);

The asterisk placement seems inconsistent here.

> Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:72
> +WEBKIT_API gboolean 
webkit_dom_event_target_add_event_listener(WebKitDOMEventTarget *target,
> +								   const char  
	*eventName,
> +								   GCallback   
	 handler,
> +								   gboolean    
	 bubble,
> +								   gpointer    
	 userData);
> +
> +WEBKIT_API gboolean 
webkit_dom_event_target_remove_event_listener(WebKitDOMEventTarget *target,
> +								      const
char	       *eventName,
> +								      GCallback
	    handler,
> +								      gboolean 
	    bubble);
> +

And here as well.