[webkit-reviews] review granted: [Bug 56294] Web Inspector: migrate from Inspector.idl to InspectorAPI.json for protocol schema definition meta bug. : [Attachment 86170] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 56294: Web Inspector: migrate from Inspector.idl to InspectorAPI.json for
protocol schema definition meta bug.
https://bugs.webkit.org/show_bug.cgi?id=56294

Attachment 86170: Patch
https://bugs.webkit.org/attachment.cgi?id=86170&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86170&action=review

> Source/WebCore/inspector/generate-inspector-idl:36
> +    # Python 3, change to: print("Usage: %s -o OUTPUT_FILE INPUT_FILE" %
program_name, file=sys.stderr)

Remove this confusing comment.

> Source/WebCore/inspector/generate-inspector-idl:106
> +	   output_file.write("\n#if defined(ENABLE_%s) && ENABLE_%s" %
(macro_traits[domain["domain"]], macro_traits[domain["domain"]]))

Please extract macro_traits[domain["domain"]] int a variable. It's repeated 4
times.