[webkit-reviews] review denied: [Bug 46695] Invalid pointer access & incomplete memcmp in setUpIterator : [Attachment 83185] Using RefPtr's to safely reuse textiterators

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 18 09:13:54 PDT 2011


Andreas Kling <kling at webkit.org> has denied chris reiss
<christopher.reiss at nokia.com>'s request for review:
Bug 46695: Invalid pointer access & incomplete memcmp in setUpIterator
https://bugs.webkit.org/show_bug.cgi?id=46695

Attachment 83185: Using RefPtr's to safely reuse textiterators
https://bugs.webkit.org/attachment.cgi?id=83185&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
This patch needs to be updated to match the current code in
TextBreakIteratorQt.
I'm not sure the patch makes sense anymore though, is there still a performance
issue with the cross-platform optimization in place?


More information about the webkit-reviews mailing list