[webkit-reviews] review denied: [Bug 56643] Web Inspector: implement inspector session storage. : [Attachment 86160] Patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 56643: Web Inspector: implement inspector session storage.
https://bugs.webkit.org/show_bug.cgi?id=56643

Attachment 86160: Patch.
https://bugs.webkit.org/attachment.cgi?id=86160&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86160&action=review

> Source/WebCore/WebCore.exp.in:1283
> +__ZN7WebCore15InspectorClient18loadSessionSettingERKN3WTF6StringEPS2_

Mind alphabetic order. Also most of the inspector symbols are guarded by #if
ENABLE(INSPECTOR) (see
http://trac.webkit.org/browser/trunk/Source/WebCore/WebCore.exp.in#L1489) , you
should move this couple there as well.

> Source/WebCore/inspector/InspectorClient.h:59
> +    void saveSessionSetting(const String& key, const String& value);

InspectorClient API has nothing to do with these storage. The fact that the
session storage is implemented on the inspector client is platform-specific and
should be implemented in the WebKit layer.

> Source/WebCore/inspector/InspectorFrontendHost.cpp:225
> +    m_client->saveSessionSetting(key, value);

You should check that the client has not been disconnected yet as in the other
methods.

> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:207
> +    InspectorClient* client = [m_windowController.get() inspectorClient];

You should use platform-specific storage here, generic interface shouldn't
contain session storage methods.