[webkit-reviews] review granted: [Bug 56555] [Qt] Enable GraphicsContext3D only when the window surface support OpenGL : [Attachment 86138] Check AC on creation of WebGLRenderingContext

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jarkko Sakkinen
<jarkko.j.sakkinen at gmail.com>'s request for review:
Bug 56555: [Qt] Enable GraphicsContext3D only when the window surface support
OpenGL
https://bugs.webkit.org/show_bug.cgi?id=56555

Attachment 86138: Check AC on creation of WebGLRenderingContext
https://bugs.webkit.org/attachment.cgi?id=86138&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86138&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:469
> +    QWebPageClient* webPageClient = m_hostWindow->platformPageClient();
> +
> +    QAbstractScrollArea* scrollArea =
qobject_cast<QAbstractScrollArea*>(webPageClient->ownerWidget());

I would remove that unneeded newline

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:472
> +    if (scrollArea)
> +	   return qobject_cast<QGLWidget*>(scrollArea->viewport());

Doesn't casting 0 return a 0? Just wondered if you could do "return qobject..."