[webkit-reviews] review granted: [Bug 56582] Update CSP directive parser to match spec : [Attachment 86084] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 17 16:19:39 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 56582: Update CSP directive parser to match spec
https://bugs.webkit.org/show_bug.cgi?id=56582

Attachment 86084: Patch
https://bugs.webkit.org/attachment.cgi?id=86084&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86084&action=review

Looks reasonable.

> Source/WebCore/page/ContentSecurityPolicy.cpp:42
> +static void advanceUntil(const UChar*& pos, const UChar* end, UChar
delimiter)

I take it you don't need to return success vs. failure here?


More information about the webkit-reviews mailing list