[webkit-reviews] review denied: [Bug 55506] [Chromium] Canvas shadow is not working with drawImage : [Attachment 86058] Code change is the same as previous patch. Changes were submitted to Skia in the mean time to prevent chromium canary test failures. Tests that need re-baselineing were marked in test expectations.

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Justin Novosad
<junov at chromium.org>'s request for review:
Bug 55506: [Chromium] Canvas shadow is not working with drawImage
https://bugs.webkit.org/show_bug.cgi?id=55506

Attachment 86058: Code change is the same as previous patch. Changes were
submitted to Skia in the mean time to prevent chromium canary test failures. 
Tests that need re-baselineing were marked in test expectations.
https://bugs.webkit.org/attachment.cgi?id=86058&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86058&action=review

The code changes look fine but the ChangeLogs need to be updated.

> Source/WebCore/ChangeLog:10
> +	   Fixes shadow blur quality and color. Also fixes shadows behind
> +	   bitmaps. Affects Chromium win/linux. Fixes the following bugs:
> +	   https://bugs.webkit.org/show_bug.cgi?id=50112
> +	   https://bugs.webkit.org/show_bug.cgi?id=51989
> +	   https://bugs.webkit.org/show_bug.cgi?id=55506
> +	   https://bugs.webkit.org/show_bug.cgi?id=55410

Please update this ChangeLog into the following format:

[Chromium] Canvas shadow is not working with drawImage
https://bugs.webkit.org/show_bug.cgi?id=55506

Followed by the extended comment including the additional bug URLs. The commit
queue will pick up the first one in the ChangeLog entry (I'm pretty sure), so
you want it to match the bug ID the patch is attached to.

> LayoutTests/ChangeLog:10
> +	   Fixes shadow blur quality and color. Also fixes shadows behind      
	   bitmaps. Affects Chromium win/linux. Fixes the following bugs:
> +	   https://bugs.webkit.org/show_bug.cgi?id=50112
> +	   https://bugs.webkit.org/show_bug.cgi?id=51989
> +	   https://bugs.webkit.org/show_bug.cgi?id=55506
> +	   https://bugs.webkit.org/show_bug.cgi?id=55410
> +	   No tests were added, impact is already covered by multiple layout
tests.

Same comment about ChangeLog formatting.