[webkit-reviews] review denied: [Bug 56555] [Qt] Enable GraphicsContext3D only when the window surface support OpenGL : [Attachment 86062] Fixed indentation

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Jarkko Sakkinen
<jarkko.j.sakkinen at gmail.com>'s request for review:
Bug 56555: [Qt] Enable GraphicsContext3D only when the window surface support
OpenGL
https://bugs.webkit.org/show_bug.cgi?id=56555

Attachment 86062: Fixed indentation
https://bugs.webkit.org/attachment.cgi?id=86062&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86062&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:474
> +    PageClientQWidget* webPageClient
> +	   =
static_cast<PageClientQWidget*>(m_hostWindow->platformPageClient());

This should be on one line.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:488
> +    PageClientQWidget* webPageClient
> +	   =
static_cast<PageClientQWidget*>(m_hostWindow->platformPageClient());

This should be on one line.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:504
> +    QGLWidget* viewportGLWidget = getViewportGLWidget();
> +    if (testAcceleratedCompositing()
> +	       && viewportGLWidget
> +	       && viewportGLWidget == m_viewportGLWidget
> +	       && viewportGLWidget == painter->device()) {

I would put those test as the first statements of the functions, and return if
not true.

That way it is clear, if the initial condition are not correct, just return.