[webkit-reviews] review granted: [Bug 56547] Add a few Objective-C++ files to the WebCore GYP build : [Attachment 86038] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 17 00:16:41 PDT 2011
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 56547: Add a few Objective-C++ files to the WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56547
Attachment 86038: Patch
https://bugs.webkit.org/attachment.cgi?id=86038&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86038&action=review
OK.
> Source/WebCore/gyp/WebCore.gyp:73
> ['exclude', 'bridge/testbindings\\.cpp$'], # Remove from GYPI?
> + ['exclude', 'bridge/testbindings\\.mm$'], # Remove from GYPI?
Why not a pattern here?
More information about the webkit-reviews
mailing list