[webkit-reviews] review denied: [Bug 56505] Add a test for r81266 and fix HTML Editing for fallback contents in object element : [Attachment 86010] 56505

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 16 20:36:42 PDT 2011


Ojan Vafai <ojan at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 56505: Add a test for r81266 and fix HTML Editing for fallback contents in
object element
https://bugs.webkit.org/show_bug.cgi?id=56505

Attachment 86010: 56505
https://bugs.webkit.org/attachment.cgi?id=86010&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86010&action=review

Looks like only the last case's "world" is bolded. I assuem that's a bug in the
test case.

> LayoutTests/editing/editability/ignored-content.html:34
> +for (var i = 0; i < (text.length + 1) * test.childNodes.length - 1; i++)
> +    window.getSelection().modify('extend', 'forward', 'character');

for loops should always have curly braces.


More information about the webkit-reviews mailing list