[webkit-reviews] review granted: [Bug 56511] Invalidate all NPObjects for a plug-in when that plug-in is destroyed : [Attachment 86019] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 56511: Invalidate all NPObjects for a plug-in when that plug-in is
destroyed
https://bugs.webkit.org/show_bug.cgi?id=56511

Attachment 86019: Patch
https://bugs.webkit.org/attachment.cgi?id=86019&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86019&action=review

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:86
> +	   // Get the plug-in so we can pass it to removePluginControllerProxy.
The pointer is only
> +	   // used as an identifier so it's OK to just get a weak reference.

Aliasing can happen even when a pointer is just used as an identifier. In these
cases I guess it’s OK because there’s no chance a new plug-in will be allocated
before the remove call is made.