[webkit-reviews] review granted: [Bug 56493] Drag-scrolling overlay scrollbars thumb in overflow regions does not work : [Attachment 85985] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 56493: Drag-scrolling overlay scrollbars thumb in overflow regions does not
work
https://bugs.webkit.org/show_bug.cgi?id=56493

Attachment 85985: Patch
https://bugs.webkit.org/attachment.cgi?id=85985&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85985&action=review

> Source/WebCore/rendering/RenderBlock.cpp:3860
> +    bool checkChildren = !useClip || (hasControlClip() ? controlClipRect(tx,
ty).intersects(hitTestArea) : overflowClipRect(tx, ty,
true).intersects(hitTestArea));

If we’re going to be passing constants to this, then it should be an enum
instead of a boolean.