[webkit-reviews] review denied: [Bug 56439] Get rid of nearestMailBlockquote : [Attachment 85984] Added a null pointer check to firstPositionInOrBeforeNode/lastPositionInOrAfterNode

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 56439: Get rid of nearestMailBlockquote
https://bugs.webkit.org/show_bug.cgi?id=56439

Attachment 85984: Added a null pointer check to
firstPositionInOrBeforeNode/lastPositionInOrAfterNode
https://bugs.webkit.org/attachment.cgi?id=85984&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85984&action=review

> Source/WebCore/editing/htmlediting.h:118
> +    return node && editingIgnoresContent(node) ? positionBeforeNode(node) :
firstPositionInNode(node);

This doesn't look right.  && has precedence over ?, so if |node| is NULL, we
return firstPositionInNode(NULL).  That seems safe, but in
lastPositionInOrAfterNode, we return lastPositionInNode(NULL), which calls
lastOffsetInNode(NULL), which will try to dereference NULL.