[webkit-reviews] review granted: [Bug 56438] Make Structure creation require a JSGlobalData : [Attachment 85950] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 56438: Make Structure creation require a JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=56438

Attachment 85950: Patch
https://bugs.webkit.org/attachment.cgi?id=85950&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85950&action=review

r=me if this builds and you make the change below.

> Source/JavaScriptCore/runtime/JSGlobalData.cpp:144
> +    , dummyMarkableCellStructure(JSCell::createDummyStructure(*this))

Please ensure these are initialized after heap. You need to verify that moving
the heap data member is not a performance regression. Previously, SunSpider has
shown itself to be sensitive to the location of some of those data members.