[webkit-reviews] review granted: [Bug 55237] Web Inspector: extract content loading logic from scripts panel : [Attachment 85926] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 16 11:12:17 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 55237: Web Inspector: extract content loading logic from scripts panel
https://bugs.webkit.org/show_bug.cgi?id=55237

Attachment 85926: Patch.
https://bugs.webkit.org/attachment.cgi?id=85926&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85926&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:315
> +WebInspector.SourceFileProvider.prototype = {

So SourceFileProvider has a fairly strange interface:
- addScript
- ensureSourceFileAdded
- sourceFile
- requestSourceFileContent
- scriptLocationToSourceLocation

what is it really responsible for?


More information about the webkit-reviews mailing list