[webkit-reviews] review granted: [Bug 56156] Add setting to always force compositing mode : [Attachment 85894] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Daniel Sievers
<sievers at google.com>'s request for review:
Bug 56156: Add setting to always force compositing mode
https://bugs.webkit.org/show_bug.cgi?id=56156

Attachment 85894: Patch
https://bugs.webkit.org/attachment.cgi?id=85894&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85894&action=review

Looks good!

> Source/WebCore/rendering/RenderLayerCompositor.cpp:118
> +    if (settings && settings->forceCompositingMode() &&
settings->acceleratedCompositingEnabled()
> +	   && !m_renderView->document()->frame()->tree()->parent()) {

this indentation is odd - i'd try to make it clearer that line 118 is still
inside the conditional and line 119 is not, maybe line up the &&s or something

> Source/WebCore/rendering/RenderLayerCompositor.h:279
> +    bool m_forceCompositingMode;
> +

nitpick: i think it'd be better to declare this with the other bools