[webkit-reviews] review denied: [Bug 49508] RTL: Caret can paint over letters when in the end of a line in textareas : [Attachment 85494] patch w/ layout test

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Xiaomei Ji <xji at chromium.org>'s request
for review:
Bug 49508: RTL: Caret can paint over letters when in the end of a line in
textareas
https://bugs.webkit.org/show_bug.cgi?id=49508

Attachment 85494: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=85494&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85494&action=review

You got the vertical text case wrong, so might want to make a vertical text
test (you'll have to use a normal contenteditable div for that though, since
textareas don't go vertical.)

> Source/WebCore/rendering/RenderText.cpp:533
> +	   rightEdge = cb->width();

Should be rightEdge = cb->logicalWidth();

> Source/WebCore/rendering/RenderText.cpp:536
> +	   rightEdge = max(static_cast<float>(cb->width()), rootRight);

Should be logicalWidth().