[webkit-reviews] review denied: [Bug 56407] REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior : [Attachment 85895] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 56407: REGRESSION (r81165): Assert running
editing/style/iframe-onload-crash.html with non-Mac editing behavior
https://bugs.webkit.org/show_bug.cgi?id=56407

Attachment 85895: Patch
https://bugs.webkit.org/attachment.cgi?id=85895&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r- I think there are comments waiting to be addressed. Plus there are at least
three skipped files that should be modified which aren't in this patch.

Please consider the cost imposed on lots of people when leaving stuff like this
in the tree. (Several people had to investigate this failure, search bugs,
modify skipped list, add comments here, etc.) In order words, it may seem good
to leave an improvement in the tree but it imposes a cost on lots of other
people.

In addition leaving asserts in the tree makes it harder for people to use debug
builds to test things because they may hit this assert and think something it
wrong etc.

If an assert will only take a short time to fix, then it will only take a short
while to get in the original patch. If it will take along while to fix, then
the patch shouldn't be left in anyway.

In short, please consider rolling out in the future.