[webkit-reviews] review requested: [Bug 55501] [Qt][WK2] Loading an empty URL crashes : [Attachment 85921] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 16 03:52:54 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has asked  for review:
Bug 55501: [Qt][WK2] Loading an empty URL crashes
https://bugs.webkit.org/show_bug.cgi?id=55501

Attachment 85921: Patch
https://bugs.webkit.org/attachment.cgi?id=85921&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
> Let's use the QWKPage::engineConnectionChanged() signal to find out if the
web process crashed.
> This test would never fail, since the autotest process cruises along happily.


Good point, I did not realize crashing the WebProcess would not have side
effects on the test. Patch updated.


More information about the webkit-reviews mailing list