[webkit-reviews] review granted: [Bug 56389] Web Inspector: split InspectorAgent.populateScriptObjects into more granular agent-specific requests : [Attachment 85909] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 56389: Web Inspector: split InspectorAgent.populateScriptObjects into more
granular agent-specific requests
https://bugs.webkit.org/show_bug.cgi?id=56389

Attachment 85909: Patch
https://bugs.webkit.org/attachment.cgi?id=85909&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85909&action=review

> Source/WebCore/inspector/InspectorAgent.cpp:401
> +	   m_frontend->inspector()->showPanel(m_showPanelAfterVisible);

Just an FYI, no action required: I am still not a fan of it. We should make
WebInspector contribute to the Develop menu instead. Hence we would not need to
be involved with the panel names on the backend side. Maybe a FIXME here.