[webkit-reviews] review granted: [Bug 56350] Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects : [Attachment 85827] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 56350: Fix crash caused by Invalid call to destroyActiveDOMObject during
stopActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=56350

Attachment 85827: Patch
https://bugs.webkit.org/attachment.cgi?id=85827&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85827&action=review

r=me

> Source/WebCore/storage/IDBDatabaseCallbacksImpl.h:45
> +    void unRegisterDatabase(IDBDatabase*);

How do we camelCaseThis elsewhere?  I think usually unregister rather than
unRegister?

> Source/WebCore/storage/IDBDatabaseCallbacksImpl.h:51
> +    // If a RefPtr were used here, there'd be a cycle and the ref counting

It seems like this could be more concise.