[webkit-reviews] review granted: [Bug 52642] Get rid of firstDeepEditingPositionForNode and lastDeepEditingPositionForNode : [Attachment 85841] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 15 12:28:23 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 52642: Get rid of firstDeepEditingPositionForNode and
lastDeepEditingPositionForNode
https://bugs.webkit.org/show_bug.cgi?id=52642

Attachment 85841: Patch
https://bugs.webkit.org/attachment.cgi?id=85841&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85841&action=review

> Source/WebCore/dom/Position.cpp:244
> +    // FIXME: Explicitly handle before/after positions

I don't think these comments are valuable.  It's clear from the fact it calls
deprecatedEditingOffset().


More information about the webkit-reviews mailing list