[webkit-reviews] review denied: [Bug 55501] [Qt][WK2] Loading an empty URL crashes : [Attachment 85817] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 15 11:58:46 PDT 2011


Andreas Kling <kling at webkit.org> has denied Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 55501: [Qt][WK2] Loading an empty URL crashes
https://bugs.webkit.org/show_bug.cgi?id=55501

Attachment 85817: Patch
https://bugs.webkit.org/attachment.cgi?id=85817&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85817&action=review

>
Source/WebKit2/UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:9
9
> +    // That should not crash.
> +    m_view->show();
> +    m_view->m_webView->load(QUrl());
> +    QTest::qWait(50);
> +
> +    m_view->m_webView->load(QUrl(""));
> +    QTest::qWait(50);

Let's use the QWKPage::engineConnectionChanged() signal to find out if the web
process crashed.
This test would never fail, since the autotest process cruises along happily.


More information about the webkit-reviews mailing list