[webkit-reviews] review granted: [Bug 55217] [GStreamer] Frame accurate seeking isn't always accurate : [Attachment 85789] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 55217: [GStreamer] Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=55217

Attachment 85789: proposed patch
https://bugs.webkit.org/attachment.cgi?id=85789&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85789&action=review

Looks good to me!

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:524
> +    GTimeVal timeValue;
> +    float seconds;
> +    float microSeconds = modf(time, &seconds) * 1000000;
> +    timeValue.tv_sec = static_cast<glong>(seconds);
> +    timeValue.tv_usec = static_cast<glong>(roundf(microSeconds / 10000) *
10000);

Super nit here, but do you mind moving GTimeVal timeValue right down to where
you first use it?