[webkit-reviews] review granted: [Bug 56305] Web Inspector: refactor event listener breakpoints. : [Attachment 85667] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 15 02:36:19 PDT 2011
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 56305: Web Inspector: refactor event listener breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=56305
Attachment 85667: Patch.
https://bugs.webkit.org/attachment.cgi?id=85667&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85667&action=review
> LayoutTests/inspector/debugger/event-listener-breakpoints.html:19
> + element.dispatchEvent(event);
Can you use element.click() instead?
> Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp:123
> + return;
You should return error string here, I believe. Same for the methods below.
> Source/WebCore/inspector/front-end/BreakpointManager.js:84
> + BrowserDebuggerAgent.setEventListenerBreakpoint(eventName);
I'd probably inline this method.
More information about the webkit-reviews
mailing list