[webkit-reviews] review granted: [Bug 56196] Some class members were used prior to initialization : [Attachment 85478] Patch with member initialization to default values.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Chris Mumford
<chris.mumford at palm.com>'s request for review:
Bug 56196: Some class members were used prior to initialization
https://bugs.webkit.org/show_bug.cgi?id=56196

Attachment 85478: Patch with member initialization to default values.
https://bugs.webkit.org/attachment.cgi?id=85478&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85478&action=review

I'm hesitating to accept this patch without tests.  Usually we require all
patches to have associated tests, if they change any observable behavior.  In
this case, you should be able to write a test that trigger the UMRs.  However,
I'm marking this patch r+ because I'd like to encourage you to upstream more
patches.  Thanks for the patch.

> Source/WebCore/accessibility/AccessibilityImageMapLink.cpp:45
> +    , m_parent(0)

wow!

> Source/WebCore/xml/XPathResult.cpp:45
> +    , m_nodeSetPosition(0)
> +    , m_domTreeVersion(0)

!