[webkit-reviews] review requested: [Bug 56290] [EFL] Add ContextMenuClientEfl to efl port : [Attachment 85783] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 56290: [EFL] Add ContextMenuClientEfl to efl port
https://bugs.webkit.org/show_bug.cgi?id=56290

Attachment 85783: Patch
https://bugs.webkit.org/attachment.cgi?id=85783&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Hello Lucas,

Is USE_CROSS_PLATFORM_CONTEXT_MENUS feature working ? It doesn't looks like to
be implemented completely. GTK port also doesn't enable the macro as well.
I think we need to have ContextMenuClientEfl. Because, we need to use functions
of ContextMenuClient.h for context menu.

#if USE(CROSS_PLATFORM_CONTEXT_MENUS)
	virtual PassOwnPtr<ContextMenu> customizeMenu(PassOwnPtr<ContextMenu>)
= 0;
#else
	virtual PlatformMenuDescription
getCustomMenuFromDefaultItems(ContextMenu*) = 0;
#endif

	virtual void contextMenuItemSelected(ContextMenuItem*, const
ContextMenu*) = 0;

	virtual void downloadURL(const KURL& url) = 0;
	virtual void searchWithGoogle(const Frame*) = 0;
	virtual void lookUpInDictionary(Frame*) = 0;
	virtual bool isSpeaking() = 0;
	virtual void speak(const String&) = 0;
	virtual void stopSpeaking() = 0;

If we start to use the CROSS_PLATFORM_CONTEXT_MENUS feature, we can't use above
functions. As you said, if the CROSS_PLATFORM_CONTEXT_MENU replaces context
menu client implementation, why don't we enable it after finishing it's
implementation ? I revise my patch.


BTW, I fix a build break regarding SHARED_CORE. Now you can build EWebKit with
cmake ../Source -DPORT=Efl -DSHARED_CORE=ON