[webkit-reviews] review granted: [Bug 56357] about:blank fake responses don't get serialized when sent the UIProcess : [Attachment 85766] With test.

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 56357: about:blank fake responses don't get serialized when sent the
UIProcess
https://bugs.webkit.org/show_bug.cgi?id=56357

Attachment 85766: With test.
https://bugs.webkit.org/attachment.cgi?id=85766&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85766&action=review

> Tools/TestWebKitAPI/PlatformUtilities.h:46
> +WKStringRef copyMIMETypeForWKURLResponse(WKURLResponseRef);

WKRetainPtr?

> Tools/TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:37
> +static void decidePolicyForResponse(WKPageRef page, WKFrameRef frame,
WKURLResponseRef response, WKURLRequestRef request, WKFramePolicyListenerRef
listener, WKTypeRef userData, const void* clientInfo)

Could remove unused arguments.

> Tools/TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:39
> +    WKRetainPtr<WKStringRef> MIMEType(AdoptWK,
Util::copyMIMETypeForWKURLResponse(response));

You don't like Util::adoptWK.

> Tools/TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:54
> +    policyClient.version = 0;

NOT NEEDED!

> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:82
> +    RetainPtr<CFURLResponseRef> response(AdoptNS,
WKURLResponseCopyCFURLResponse(0, wkResponse));

AdoptCF please.