[webkit-reviews] review denied: [Bug 56350] Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects : [Attachment 85752] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 56350: Fix crash caused by Invalid call to destroyActiveDOMObject during
stopActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=56350

Attachment 85752: Patch
https://bugs.webkit.org/attachment.cgi?id=85752&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85752&action=review

close

> Source/WebCore/ChangeLog:7
> +

Please add some more detail and explain why it only affects multi-process.

> Source/WebCore/storage/IDBDatabase.h:118
> +    RefPtr<IDBDatabaseCallbacks> m_databaseCallbacks;

Save the impl here.

> Source/WebCore/storage/IDBDatabaseCallbacks.h:36
> +class IDBDatabase;

don't add

> Source/WebCore/storage/IDBDatabaseCallbacks.h:43
> +    virtual void unRegisterDatabase(IDBDatabase*) { ASSERT_NOT_REACHED(); };


don't add

> Source/WebCore/storage/IDBDatabaseCallbacksImpl.h:42
> +    virtual ~IDBDatabaseCallbacksImpl() { }

Don't inline.

> Source/WebCore/storage/IDBDatabaseCallbacksImpl.h:48
> +    IDBDatabaseCallbacksImpl(IDBDatabase*);

newline after

explain why this needs to be weak in comment?