[webkit-reviews] review denied: [Bug 56338] Introduce NonThreadSpecific template : [Attachment 85730] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 17:35:43 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has denied Nat Duca <nduca at chromium.org>'s
request for review:
Bug 56338: Introduce NonThreadSpecific template
https://bugs.webkit.org/show_bug.cgi?id=56338

Attachment 85730: Patch
https://bugs.webkit.org/attachment.cgi?id=85730&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't think that this would be useful in WebKit. We strongly prefer message
passing to having any shared data, so no assertions beyond
ASSERT(isMainThread()) in a few methods should be necessary in practice.

All data is single threaded by default, and as long as we stick to that at
design stage, runtime assertions are a weak and unnecessary way to guarantee
the same.


More information about the webkit-reviews mailing list