[webkit-reviews] review denied: [Bug 48382] Autofilled form elements are assigned fixed background color but not text color : [Attachment 85529] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 48382: Autofilled form elements are assigned fixed background color but not
text color
https://bugs.webkit.org/show_bug.cgi?id=48382

Attachment 85529: Patch
https://bugs.webkit.org/attachment.cgi?id=85529&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85529&action=review

If you fix the 2 minor issues mentioned below and upload a new patch, I'll r+
and cq+.

> LayoutTests/platform/win/fast/forms/input-autofilled-expected.txt:3
> +This tests that foreground and background colors properly change for
autofilled inputs. It can only be run using DumpRenderTree.
> +
> +FAIL Foreground color did not change when autofilled.

I would remove this file and just add the file to
LayoutTests/platform/win/Skipped with a comment saying that
layoutTestController.setAutofilled needs to be implemented.

> Tools/DumpRenderTree/LayoutTestController.cpp:2121
> +	   { "setAutofilled", setAutofilledCallback,
kJSPropertyAttributeDontDelete },

Should we also set kJSPropertyAttributeReadOnly?