[webkit-reviews] review denied: [Bug 56331] FileSystemWin.cpp needs listDirectory() implementation : [Attachment 85726] [PATCH] Fix v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 14 15:04:16 PDT 2011
Gavin Barraclough <barraclough at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 56331: FileSystemWin.cpp needs listDirectory() implementation
https://bugs.webkit.org/show_bug.cgi?id=56331
Attachment 85726: [PATCH] Fix v3
https://bugs.webkit.org/attachment.cgi?id=85726&action=review
------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85726&action=review
> Source/JavaScriptCore/wtf/text/StringConcatenate.h:111
> + memcpy(destination, m_buffer, m_length * sizeof(UChar));
please cast m_length to size_t before multiplying, this might overflow.
More information about the webkit-reviews
mailing list