[webkit-reviews] review requested: [Bug 56043] Leaks Viewer should present a list of recent builds to analyze : [Attachment 85721] Show a list of up to 10 recent leaky builds when Leaks Viewer loads

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 56043: Leaks Viewer should present a list of recent builds to analyze
https://bugs.webkit.org/show_bug.cgi?id=56043

Attachment 85721: Show a list of up to 10 recent leaky builds when Leaks Viewer
loads
https://bugs.webkit.org/attachment.cgi?id=85721&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85721&action=review

Some general js comments. Nice coding style!

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksVi
ewer.js:178
> +		   link.href = document.location.href + "?url=" + build.url;

I think this should window.encodeURIComponent(build.url)

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentB
uildsLoader.js:33
> +	   url += range(maximumNumberOfBuilds).map(function(n) { return
"select=-" + (n + 1); }).join("&");

Maybe even here too (inside the map function), but this seems harmless.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentB
uildsLoader.js:57
> +			       buildInfo.leakCount = match[1];

Nit: optional, parseInt(match[1], 10) since it looks like you want this to be a
numerical value.