[webkit-reviews] review granted: [Bug 56043] Leaks Viewer should present a list of recent builds to analyze : [Attachment 85721] Show a list of up to 10 recent leaky builds when Leaks Viewer loads

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 56043: Leaks Viewer should present a list of recent builds to analyze
https://bugs.webkit.org/show_bug.cgi?id=56043

Attachment 85721: Show a list of up to 10 recent leaky builds when Leaks Viewer
loads
https://bugs.webkit.org/attachment.cgi?id=85721&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85721&action=review

r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksVi
ewer.js:123
> +	   loader.start("SnowLeopard Intel Leaks",
this._numberOfRecentBuildsToLoad);

Nit: I guess this is okay to hard-code.  Eventually, we may want another way to
pick from a list of bots?

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksVi
ewer.js:192
> +	       recentBuildsContainer.appendChild(document.createTextNode("No
recent leaky builds found"));

Nit:  Should say:  "No recent leaky builds found.  Go home."  (At least
consider adding a period to the existing message. :)