[webkit-reviews] review granted: [Bug 56331] FileSystemWin.cpp needs listDirectory() implementation : [Attachment 85716] [PATCH] Fix

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 56331: FileSystemWin.cpp needs listDirectory() implementation
https://bugs.webkit.org/show_bug.cgi?id=56331

Attachment 85716: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=85716&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85716&action=review

> Source/WebCore/platform/win/FileSystemWin.cpp:307
> +    String windowsSpecificFilter = "\\" + filter;
> +    PathWalker walker(directory, windowsSpecificFilter);

Please just pass filter through here.

> Source/WebCore/platform/win/FileSystemWin.cpp:316
> +	   String fileName = walker.data().cFileName;
> +	   entries.append(makeString(directory, "\\", fileName));

This will (I think) be more efficient if you remove the local fileName
variable.

> Source/WebCore/platform/win/PathWalker.cpp:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

2011!

> Source/WebCore/platform/win/PathWalker.cpp:54
> +bool PathWalker::isValid() const
> +{
> +    return m_handle != INVALID_HANDLE_VALUE;
> +}
> +
> +const WIN32_FIND_DATAW& PathWalker::data() const
> +{
> +    return m_data;
> +}

I think these could go in the header.