[webkit-reviews] review requested: [Bug 55416] Viewport no longer allows an auto value for "user-scalable" : [Attachment 85714] [PATCH] Improve: Add userScalable to LayoutTests print statements
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 14 13:47:21 PDT 2011
Joseph Pecoraro <joepeck at webkit.org> has asked for review:
Bug 55416: Viewport no longer allows an auto value for "user-scalable"
https://bugs.webkit.org/show_bug.cgi?id=55416
Attachment 85714: [PATCH] Improve: Add userScalable to LayoutTests print
statements
https://bugs.webkit.org/attachment.cgi?id=85714&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Updates:
• 1.0f and 0.0f => 1 and 0
• (userScalable != 0.0) => static_cast<bool>(userScalable)
• updated ChangeLogs
• Test printf statements
- fprintf(stdout, "viewport size %dx%d scale %f with limits [%f, %f]\n",
...
+ fprintf(stdout, "viewport size %dx%d scale %f with limits [%f, %f] and
userScalable %f\n", ...
This would need to be manually landed since ALL viewport tests will
change, and I'll need to update them once I can pull from the bots.
More information about the webkit-reviews
mailing list